Fix missing MatchErrors due to hash collisions #4307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
requested review from
audgirka and
alisonlhart
and removed request for
a team
cavcrosby
force-pushed
the
fix-matcherrors-hash-collision
branch
from
1e33f8b
to
98558ff
Compare
cavcrosby
force-pushed
the
fix-matcherrors-hash-collision
branch
from
98558ff
to
f3f0b38
Compare
|
|
I think the function ansible-lint/src/ansiblelint/errors.py Lines 144 to 156 in 7a78006 |
Setting the filename for match_error has been removed because this will be done on MatchError instance creation via the __post_init__ method.
ssbarnea
force-pushed
the
fix-matcherrors-hash-collision
branch
from
f3f0b38
to
e5f7841
Compare
ssbarnea
approved these changes
Sep 19, 2024
|
@marcandre-larochelle-bell I apologize for not getting around to your comment until now. I think it's fine to continue using the |
|
@cavcrosby No worries, I was mostly wondering, thanks for the reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4297.
This fix follows what was done here, #4202, for transitioning to passing a
lintableargument forMatchErrorobject construction instead of afilenameargument. I also noticed a few places insrc/ansiblelint/utils.pywhere this problem could be reproduced. Hence, I figured now would be a good time to address those spots as well.